-
Notifications
You must be signed in to change notification settings - Fork 12
Cps 44 Product Configuration params, templates and other updates #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cps 44 Product Configuration params, templates and other updates #68
Conversation
JaviCerveraIngram
commented
Sep 26, 2019
- Get product templates and configuration params.
- Added missing fields and methods to models.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 92.81% 92.76% -0.05%
==========================================
Files 65 67 +2
Lines 1739 1866 +127
==========================================
+ Hits 1614 1731 +117
- Misses 125 135 +10
Continue to review full report at Codecov.
|
ht-albert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think need reorganizate import
| @post_load | ||
| def make_object(self, data): | ||
| from connect.models import Country | ||
| return Country(**data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think model import is fast
why do we need import here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every model needs to know its schema for its deserialize method to work. Every schema needs to know its model for its make_object method to work. Thus, one of the files need to import the other locally to avoid a cyclic import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood you, all schemas in one file, therefore, such imports, it is okay for me