-
Notifications
You must be signed in to change notification settings - Fork 12
Cps 59 accept null #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cps 59 accept null #76
Conversation
JaviCerveraIngram
commented
Oct 22, 2019
- Added a few missing methods and properties.
- Accepted null on JSON fields of the response, to prevent an error commonly reported that the SDK is not capable of parsing the response given by Connect.
- Improved Fulfillment example of the documentation.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 92.72% 92.74% +0.02%
==========================================
Files 67 67
Lines 1910 1916 +6
==========================================
+ Hits 1771 1777 +6
Misses 139 139
Continue to review full report at Codecov.
|
marcserrat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently i don't like the fix:
a) Either you set the oones that basicly are populated
b) Either globally you relax all since you relay on the platform.
this way seams bit strange mixure