Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

  • Added a few missing methods and properties.
  • Accepted null on JSON fields of the response, to prevent an error commonly reported that the SDK is not capable of parsing the response given by Connect.
  • Improved Fulfillment example of the documentation.

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #76 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   92.72%   92.74%   +0.02%     
==========================================
  Files          67       67              
  Lines        1910     1916       +6     
==========================================
+ Hits         1771     1777       +6     
  Misses        139      139
Impacted Files Coverage Δ
connect/models/schemas.py 93.12% <100%> (+0.05%) ⬆️
connect/models/asset.py 96.22% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e91f0...da6c373. Read the comment docs.

Copy link
Contributor

@marcserrat marcserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently i don't like the fix:
a) Either you set the oones that basicly are populated
b) Either globally you relax all since you relay on the platform.

this way seams bit strange mixure

@marcserrat marcserrat merged commit 17e5239 into cloudblue:master Oct 23, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-59-accept-null branch October 23, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants