Skip to content

CPS-63 Fixed error parsing null values on some models. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgrebenschikov merged 1 commit into from
Oct 25, 2019
Merged

CPS-63 Fixed error parsing null values on some models. #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions connect/models/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def make_object(self, data):
return ContactInfo(**data)


class ValueChoiceSchema(Schema):
class ValueChoiceSchema(BaseSchema):
value = fields.Str()
label = fields.Str()

Expand Down Expand Up @@ -215,7 +215,7 @@ def _deserialize(self, value, attr, obj, **kwargs):
raise ValueError({attr: [u'Not a valid int or string.']})


class ExtIdHubSchema(Schema):
class ExtIdHubSchema(BaseSchema):
hub = fields.Nested(HubSchema, only=('id', 'name'))
external_id = ExternalIdField()

Expand Down Expand Up @@ -471,7 +471,7 @@ def make_object(self, data):
return Product(**data)


class ServerErrorResponseSchema(Schema):
class ServerErrorResponseSchema(BaseSchema):
error_code = fields.Str()
params = fields.Dict()
errors = fields.Str(many=True)
Expand Down Expand Up @@ -514,7 +514,7 @@ def make_object(self, data):
return TierAccount(**data)


class TierAccountsSchema(Schema):
class TierAccountsSchema(BaseSchema):
customer = fields.Nested(TierAccountSchema)
tier1 = fields.Nested(TierAccountSchema)
tier2 = fields.Nested(TierAccountSchema)
Expand Down