Fix ServerErrorResponseSchema and function_log decorator #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 92.66% 92.66% +<.01%
==========================================
Files 67 67
Lines 1922 1923 +1
==========================================
+ Hits 1781 1782 +1
Misses 141 141
Continue to review full report at Codecov.
|
ghost
commented
Nov 19, 2019
| custom_logger = logging.getLogger() | ||
| sformat = " %(levelname)-6s; %(asctime)s; %(name)-6s; %(module)s:%(funcName)s:line" \ | ||
| "-%(lineno)d: %(message)s" | ||
| [handler.setFormatter(logging.Formatter(sformat, "%I:%M:%S")) |
Author
There was a problem hiding this comment.
this line allocates a list in memory that is never used
vgrebenschikov
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerErrorResponseSchemahas a wrong definition of theerrorsfield. It must be a list of strings.function_logcreates a list with the result of the invocation of the setFormatter method for each logging handler configured for a logger (a list of None's), but the list is never used.