Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

I don't need a release with this fix, since there are more PRs coming very soon.

@marcserrat marcserrat requested review from a user and martinconstante March 23, 2020 12:20
@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #91 into master will decrease coverage by 0.13%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   93.03%   92.90%   -0.14%     
==========================================
  Files          69       69              
  Lines        2025     2030       +5     
==========================================
+ Hits         1884     1886       +2     
- Misses        141      144       +3     
Impacted Files Coverage Δ
connect/resources/base.py 91.83% <62.50%> (-2.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8285722...a24149d. Read the comment docs.

Copy link
Collaborator

@martinconstante martinconstante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@marcserrat marcserrat merged commit d814325 into cloudblue:master Mar 23, 2020
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-76-rql-fix branch March 23, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants