Skip to content

Conversation

@martinconstante
Copy link
Collaborator

@martinconstante martinconstante commented Apr 3, 2020

Creation of Tier Account Request functionality
Tier Account Request Automation
Creation of methods Tier Config Request
Creation of Billing Request functionality
Creation of Subscriptions Assets functionality

@martinconstante martinconstante requested review from a user and vgrebenschikov April 3, 2020 17:13
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .pylintrc since this project use flake8

@marcserrat marcserrat requested a review from d3rky April 7, 2020 09:56
@ghost ghost self-requested a review April 8, 2020 07:47
@codecov-io
Copy link

Codecov Report

Merging #93 into master will increase coverage by 0.71%.
The diff coverage is 94.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   92.90%   93.62%   +0.71%     
==========================================
  Files          69       86      +17     
  Lines        2030     2619     +589     
==========================================
+ Hits         1886     2452     +566     
- Misses        144      167      +23     
Impacted Files Coverage Δ
connect/exceptions.py 98.18% <ø> (+0.03%) ⬆️
connect/logger/__init__.py 100.00% <ø> (ø)
connect/logger/logger.py 100.00% <ø> (ø)
connect/models/activation.py 100.00% <ø> (ø)
connect/models/activation_template_response.py 100.00% <ø> (ø)
connect/models/activation_tile_response.py 100.00% <ø> (ø)
connect/models/agreement.py 100.00% <ø> (ø)
connect/models/agreement_stats.py 100.00% <ø> (ø)
connect/models/asset.py 96.22% <ø> (ø)
connect/models/base.py 95.23% <ø> (+0.79%) ⬆️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d814325...f924752. Read the comment docs.

@marcserrat marcserrat merged commit a0c504c into master Apr 16, 2020
@marcserrat marcserrat deleted the dev_V19 branch April 16, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants