Skip to content

Conversation

@paulinaczybir
Copy link
Collaborator

@paulinaczybir paulinaczybir commented May 8, 2024

  • Use ES Modules instead of CommonJs
  • Replace webpack build with vite build
  • replace testing library from jest to vitest
  • upgrade storybook 8 and add support to work with vite

IMPROVEMENTS in the future:

  • bringing back svg mock to not load all icons for tests (didn't find way to replace by vitest config how vite deals with icons)
  • storybook initial loading time is surprisingly long :(

@paulinaczybir paulinaczybir force-pushed the feature/LITE-29730-migrate-to-esm-and-from-webpack-to-vite branch from 500a5d5 to 6623c59 Compare May 9, 2024 16:22
@paulinaczybir paulinaczybir force-pushed the feature/LITE-29730-migrate-to-esm-and-from-webpack-to-vite branch from 6623c59 to 85ab60e Compare May 9, 2024 16:27
nerimartinez
nerimartinez previously approved these changes May 14, 2024
@arnaugiralt
Copy link
Member

IMPROVEMENTS in the future:

bringing back svg mock to not load all icons for tests (didn't find way to replace by vitest config how vite deals with icons)
storybook initial loading time is surprisingly long :(

Could you add these improvements as new subtasks in the UI Toolkit JIRA US?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@arnaugiralt arnaugiralt merged commit 760461d into master May 17, 2024
@arnaugiralt arnaugiralt deleted the feature/LITE-29730-migrate-to-esm-and-from-webpack-to-vite branch May 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants