fix: self-heal node-pty spawn-helper permissions at runtime#3
Open
samwei12 wants to merge 1 commit intocloudcli-ai:mainfrom
Open
fix: self-heal node-pty spawn-helper permissions at runtime#3samwei12 wants to merge 1 commit intocloudcli-ai:mainfrom
samwei12 wants to merge 1 commit intocloudcli-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS case where the official terminal plugin installs successfully but new terminal sessions disconnect immediately because
node-ptycannot spawn its helper.Closes #1.
Root cause
CloudCLI intentionally installs plugins with
npm install --ignore-scripts, so pluginpostinstallhooks are not available for fixingnode-ptypackaging issues.On macOS,
node-pty'sspawn-helpercan exist without execute permission. The plugin websocket still comes up, butpty.spawn(...)then fails and the UI drops into an immediate disconnect state.What changed
findModuleRoot()so runtime self-heal resolves the samenode-ptycopy that the plugin actually loadsensureSpawnHelperExecutable()beforepty.spawn(...)Verification
npm install --ignore-scriptsnpm run buildspawn-helper