Use existing client in List, Find, etc.#25
Merged
josiasmontag merged 1 commit intocloudconvert:masterfrom May 22, 2022
Merged
Conversation
Instead of calling `default_client()` for each of those class methods, use a new method, `get_existing_client`, which gets if a user has setup a new api client with `configure`. Solves cloudconvert#13.
BryceStevenWilley
added a commit
to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger
that referenced
this pull request
May 22, 2022
Adds a function that converts a DAFile docx to rtf and back and downloads it. Also sets up the converter in the interview. Depends on the as-of-yet unmerged PR cloudconvert/cloudconvert-python#25, which lets you use a non-default client.
Contributor
|
Thanks |
BryceStevenWilley
added a commit
to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger
that referenced
this pull request
May 30, 2022
Adds a function that converts a DAFile docx to rtf and back and downloads it. Also sets up the converter in the interview. Depends on the as-of-yet unmerged PR cloudconvert/cloudconvert-python#25, which lets you use a non-default client.
BryceStevenWilley
added a commit
to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger
that referenced
this pull request
May 30, 2022
Adds a function that converts a DAFile docx to rtf and back and downloads it. Also sets up the converter in the interview. Depends on the as-of-yet unmerged PR cloudconvert/cloudconvert-python#25, which lets you use a non-default client.
BryceStevenWilley
added a commit
to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger
that referenced
this pull request
May 31, 2022
Adds a function that converts a DAFile docx to rtf and back and downloads it. Also sets up the converter in the interview. Depends on the as-of-yet unmerged PR cloudconvert/cloudconvert-python#25, which lets you use a non-default client.
BryceStevenWilley
added a commit
to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger
that referenced
this pull request
Jun 4, 2022
Adds a function that converts a DAFile docx to rtf and back and downloads it. Also sets up the converter in the interview. Depends on the as-of-yet unmerged PR cloudconvert/cloudconvert-python#25, which lets you use a non-default client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling
default_client()for each of those class methods, use anew method,
get_existing_client, which gets if a user has setup a new apiclient with
configure.Solves #13.