Update abstract adapter stub #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes this error on a freshly generated abstract adapter: ``` Declaration of App\JsonApi\Adapters\SearchResultAdapter::exists($resourceId) must be compatible with CloudCreativity\LaravelJsonApi\Contracts\Adapter\ResourceAdapterInterface::exists(string $resourceId): bool ```
fixes ``` Declaration of App\JsonApi\Adapters\SearchResultAdapter::findMany(array $resourceIds) must be compatible with CloudCreativity\LaravelJsonApi\Contracts\Adapter\ResourceAdapterInterface::findMany(iterable $resourceIds): iterable ``` from freshly generated abstract adapter
daryledesilva
changed the title
lindyhopchris
requested changes
Oct 13, 2020
Member
lindyhopchris
left a comment
lindyhopchris
left a comment
There was a problem hiding this comment.
Thanks for submitting this. I hadn't spotted the stub was out of date! Just one change required to merge it.
Contributor
Author
@lindyhopchris Ok thanks! Done! If you merge my PR just squash it so it's cleaner 😁 cheers! |
lindyhopchris
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes these errors on a freshly generated abstract adapter: