Feature: separate out command queuing to a command queuer driving port#19
Merged
lindyhopchris merged 2 commits intonextfrom Jan 12, 2025
Merged
Feature: separate out command queuing to a command queuer driving port#19lindyhopchris merged 2 commits intonextfrom
lindyhopchris merged 2 commits intonextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the command bus exposed a
queue()method for asynchronously dispatching commands.This PR separates that out to a command queuer driving port. This is better because it means the application layer only exposes command queuing to the presentation and delivery layer if it supports it.
Additionally, it makes more sense for the queuing of internal commands. Now for internal work, the application layer just pushes commands directly to the queue driven port. An internal command bus can then be used for dispatching those queued commands - but importantly, this command bus can actually be defined as a driven port, which makes more sense as queuing commands requires infrastructure and therefore should only exist as a driven port if it is not exposed to the outside world.