Refactor: rename bus middleware interface and improve type-hint#9
Merged
lindyhopchris merged 3 commits intonextfrom Apr 8, 2024
Merged
Conversation
Member
Author
|
Needs to be squash merged as I missed updating the closure signature on the interface in the first commit. |
lindyhopchris
commented
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
MessageMiddlewareInterfacetype-hintedMessageInterface. This was incorrect - because the middleware returns a result, it can only be used with command or query messages, not integration events.The middleware interface has been renamed
BusMiddlewareInterfacewhich is more descriptive of its purpose. The message type-hint has been changed fromMessageInterfacetoCommandInterface|QueryInterface, which again is more accurate.