This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Allow to set API icons in @Api + use new Google logo#122
Closed
clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
Closed
Allow to set API icons in @Api + use new Google logo#122clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
clementdenis wants to merge 1 commit intocloudendpoints:masterfrom
Conversation
Use new Google logo for default icons (aligned with Google APIs)
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
===========================================
- Coverage 79.75% 79.6% -0.15%
- Complexity 1652 1658 +6
===========================================
Files 156 156
Lines 5536 5561 +25
Branches 710 713 +3
===========================================
+ Hits 4415 4427 +12
- Misses 843 851 +8
- Partials 278 283 +5
Continue to review full report at Codecov.
|
Contributor
|
Hey @clementdenis, thanks for the PR! Unfortunately, I have been told that the icon customization is on the deprecation path, so we shouldn't allow customization. But if you want to include the change to the new logo, I'm fine with it. |
Contributor
Author
Contributor
|
Thanks as always, Clement. I forwarded your feedback to the API Explorer team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new logo is coming from the default icon in the public API Explorer