Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Add method-level description in @ApiMethod#14

Merged
tangiel merged 3 commits intocloudendpoints:masterfrom
AODocs:method_descriptions
Oct 18, 2016
Merged

Add method-level description in @ApiMethod#14
tangiel merged 3 commits intocloudendpoints:masterfrom
AODocs:method_descriptions

Conversation

@clementdenis
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 7, 2016

Current coverage is 79.21% (diff: 90.00%)

Merging #14 into master will decrease coverage by 1.20%

@@             master        #14   diff @@
==========================================
  Files           155        155          
  Lines          4999       5118   +119   
  Methods           0          0          
  Messages          0          0          
  Branches        839        845     +6   
==========================================
+ Hits           4020       4054    +34   
- Misses          716        799    +83   
- Partials        263        265     +2   

Powered by Codecov. Last update 2f0f672...7c4a25d

Copy link
Contributor

@tangiel tangiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding this to SwaggerGenerator as well?

@clementdenis
Copy link
Contributor Author

Done, added for #15 as well.

Copy link
Contributor

@tangiel tangiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

"paths": {
"/foo/v1/foos/{id}": {
"get": {
"description":"get desc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you put spaces after the colons?

@tangiel tangiel merged commit 81be6f0 into cloudendpoints:master Oct 18, 2016
@clementdenis clementdenis deleted the method_descriptions branch July 31, 2018 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants