Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

don't generate discovery when discoverable is false#143

Merged
tangiel merged 1 commit intomasterfrom
discoverable
Apr 23, 2018
Merged

don't generate discovery when discoverable is false#143
tangiel merged 1 commit intomasterfrom
discoverable

Conversation

@tangiel
Copy link
Contributor

@tangiel tangiel commented Apr 19, 2018

No description provided.

@tangiel tangiel requested a review from inklesspen April 19, 2018 21:31
@codecov-io
Copy link

Codecov Report

Merging #143 into master will increase coverage by 0.37%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     80.02%   80.39%   +0.37%     
- Complexity     1677     1707      +30     
============================================
  Files           156      156              
  Lines          5591     5779     +188     
  Branches        729      803      +74     
============================================
+ Hits           4474     4646     +172     
- Misses          840      852      +12     
- Partials        277      281       +4
Impacted Files Coverage Δ Complexity Δ
...i/server/spi/discovery/LocalDiscoveryProvider.java 85.29% <ø> (ø) 10 <0> (ø) ⬇️
...e/api/server/spi/discovery/DiscoveryGenerator.java 91.07% <72.72%> (+2.44%) 74 <0> (+13) ⬆️
...ava/com/google/api/server/spi/auth/GoogleAuth.java 84.61% <0%> (-1.1%) 48% <0%> (+15%)
...api/server/spi/auth/GoogleOAuth2Authenticator.java 86.66% <0%> (-0.44%) 11% <0%> (+1%)
...le/api/server/spi/auth/EndpointsAuthenticator.java 100% <0%> (ø) 6% <0%> (ø) ⬇️
.../server/spi/auth/GoogleAppEngineAuthenticator.java 86.07% <0%> (+0.62%) 17% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b51f85...5c6c20f. Read the comment docs.

@tangiel tangiel merged commit e879c7e into master Apr 23, 2018
@tangiel tangiel deleted the discoverable branch April 23, 2018 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants