This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Conversation
The official documentation for a long time has disallowed underscores in API names, so I'm leaving it as such. However, for extremely old users of the old frameworks, this limitation was not in place. Therefore, I'm removing it from the API validation, but leaving the @Api documentation in order to not encourage the style.
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=========================================
Coverage 80.01% 80.01%
Complexity 1678 1678
=========================================
Files 156 156
Lines 5595 5595
Branches 730 730
=========================================
Hits 4477 4477
Misses 840 840
Partials 278 278
Continue to review full report at Codecov.
|
kryzthov
approved these changes
Jun 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official documentation for a long time has disallowed underscores
in API names, so I'm leaving it as such. However, for extremely old
users of the old frameworks, this limitation was not in
place. Therefore, I'm removing it from the API validation, but leaving
the @Api documentation in order to not encourage the style.