This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
============================================
+ Coverage 80.01% 80.08% +0.06%
- Complexity 1678 1726 +48
============================================
Files 156 156
Lines 5595 5694 +99
Branches 730 766 +36
============================================
+ Hits 4477 4560 +83
- Misses 840 844 +4
- Partials 278 290 +12
Continue to review full report at Codecov.
|
kryzthov
approved these changes
Jun 11, 2018
kryzthov
left a comment
There was a problem hiding this comment.
Looks good, just one nitpick question.
| JsonNode nodeValue = node.get(name); | ||
| if (nodeValue == null) { | ||
| params[i] = null; | ||
| if (StandardParameters.isStandardParamName(name)) { |
There was a problem hiding this comment.
Any reason to turn the else if/else into a nested else { if/else }?
It looks strictly equivalent, am I misreading?
Contributor
Author
There was a problem hiding this comment.
It was just so that the null check can exist in the newly created else block, rather than re-checking for parameter name existence. Everything else is equivalent.
kryzthov
approved these changes
Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nAmed parameters that don't have @nullable parameters are deemed
required. Endpoints v2 lost this request validation, but this change
adds it back in. Previously, the framework would assume the validation
was done.