This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Merged
Conversation
Previously we caught exceptions and printed the cause message, but this has bitten us plenty of times in the past with unhelpful exception messages. Now we just let the tool throw the exception so we get the exception type and stack trace.
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
============================================
+ Coverage 79.99% 80.04% +0.04%
- Complexity 1681 1682 +1
============================================
Files 156 156
Lines 5599 5597 -2
Branches 731 731
============================================
+ Hits 4479 4480 +1
+ Misses 840 838 -2
+ Partials 280 279 -1
Continue to review full report at Codecov.
|
inklesspen
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151.