Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Enrich and expose internal methods related to authentication#165

Merged
tangiel merged 2 commits intocloudendpoints:masterfrom
AODocs:expose_auth_internals
Sep 20, 2018
Merged

Enrich and expose internal methods related to authentication#165
tangiel merged 2 commits intocloudendpoints:masterfrom
AODocs:expose_auth_internals

Conversation

@clementdenis
Copy link
Contributor

  • add missing TokenInfo fields, and expose GoogleAuth.getTokenInfoRemote
  • Store validated TokenInfo or GoogleIdToken in request attribute, for custom Authenticators usage
  • Expose Auth/PeerAuth.instantiate(Peer)Authenticator to enforce @singleton contract
  • Add Javadoc on request Attribute constants

The main goal of these changes is to allow implementing custom Authenticators more easily and efficiently, such as what is implement in this project.
It does not change any of the existing behavior.

Clément Denis added 2 commits September 4, 2018 17:44
- add some missing TokenInfo fields, and expose GoogleAuth.getTokenInfoRemote
- Store validated TokenInfo or GoogleIdToken in request, for custom authenticators usage
- Add Javadoc on Attribute constants
@codecov-io
Copy link

Codecov Report

Merging #165 into master will decrease coverage by 0.08%.
The diff coverage is 68.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
- Coverage     80.12%   80.03%   -0.09%     
+ Complexity     1689     1687       -2     
============================================
  Files           157      158       +1     
  Lines          5629     5630       +1     
  Branches        735      734       -1     
============================================
- Hits           4510     4506       -4     
- Misses          838      843       +5     
  Partials        281      281
Impacted Files Coverage Δ Complexity Δ
...ava/com/google/api/server/spi/auth/GoogleAuth.java 80.48% <0%> (-5.23%) 33 <0> (ø)
...api/server/spi/auth/GoogleOAuth2Authenticator.java 87.5% <100%> (+0.4%) 10 <0> (ø) ⬇️
...a/com/google/api/server/spi/request/Attribute.java 100% <100%> (ø) 10 <1> (ø) ⬇️
...le/api/server/spi/auth/GoogleJwtAuthenticator.java 85.36% <100%> (+0.36%) 11 <0> (ø) ⬇️
.../server/spi/auth/GoogleAppEngineAuthenticator.java 85.45% <100%> (ø) 16 <0> (ø) ⬇️
...n/java/com/google/api/server/spi/request/Auth.java 75.86% <75%> (-1.64%) 9 <2> (-1)
.../main/java/com/google/api/server/spi/PeerAuth.java 88.88% <75%> (+2.22%) 8 <2> (-1) ⬇️
...va/com/google/api/server/spi/config/Singleton.java 76.47% <76.47%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413e434...c567c66. Read the comment docs.

@tangiel tangiel merged commit d778d66 into cloudendpoints:master Sep 20, 2018
@clementdenis clementdenis deleted the expose_auth_internals branch February 21, 2022 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants