This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Conversation
Endpoints previously bundled the Jackson annotation introspector, which didn't really have an effect when Jackson was a vendored and repackaged dependency. Now that it's an explicit dependency, the annotations can clash with previous Endpoints behavior when the annotations are used outside of an Endpoints context. This change adds an option to disable the Jackson behavior, which is done so by setting ENDPOINTS_JSON_DISABLE_JACKSON_ANNOTATIONS to a truthy value or the endpoints.json.disableJacksonAnnotations system property. Consequently, this change also refactors MapSchemaFlag into a general EndpointsFlag class for future use, as it is more flexible and easy to implement than the ServletInitializationParameters flags.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
============================================
+ Coverage 80.22% 80.24% +0.02%
- Complexity 1712 1715 +3
============================================
Files 158 158
Lines 5698 5704 +6
Branches 751 755 +4
============================================
+ Hits 4571 4577 +6
- Misses 843 844 +1
+ Partials 284 283 -1
Continue to review full report at Codecov.
|
inklesspen
suggested changes
Sep 20, 2018
endpoints-framework/src/main/java/com/google/api/server/spi/config/model/EndpointsFlag.java
Outdated
Show resolved
Hide resolved
7cd2552 to
f1c0ddb
Compare
inklesspen
approved these changes
Sep 20, 2018
61ee9b5 to
0c830cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints previously bundled the Jackson annotation introspector,
which didn't really have an effect when Jackson was a vendored and
repackaged dependency. Now that it's an explicit dependency, the
annotations can clash with previous Endpoints behavior when the
annotations are used outside of an Endpoints context.
This change adds an option to disable the Jackson behavior, which is
done so by setting ENDPOINTS_JSON_DISABLE_JACKSON_ANNOTATIONS to a
truthy value or the endpoints.json.disableJacksonAnnotations system
property.
Consequently, this change also refactors MapSchemaFlag into a general
EndpointsFlag class for future use, as it is more flexible and easy to
implement than the ServletInitializationParameters flags.