This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Conversation
* This should fix the few broken log statements throughout due to misunderstanding log string formatting * Log performance should be generally increased by saving string format operations unless they're necessary
Contributor
Author
|
Rather confusingly, the branch Travis build fails but the PR build succeeds https://travis-ci.org/cloudendpoints/endpoints-java/pull_requests and it also succeeds on my desktop. |
inklesspen
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
misunderstanding log string formatting
format operations unless they're necessary