Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Improve Swagger generation#171

Merged
tangiel merged 1 commit intocloudendpoints:masterfrom
AODocs:unique_operation_id
Oct 24, 2018
Merged

Improve Swagger generation#171
tangiel merged 1 commit intocloudendpoints:masterfrom
AODocs:unique_operation_id

Conversation

@clementdenis
Copy link
Contributor

  • Generate operation ids based on api name, version, resource name and method name to avoid conflicts
  • Try to make generated swagger files identical over runs by using only order-preserving maps => useful when Swagger spec is generated on build and versioned

- Generate operation ids based on api name, version, resource name and method name to avoid conflicts
- Try to make generated swagger files identical over runs by using only order-preserving maps
@codecov-io
Copy link

Codecov Report

Merging #171 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #171      +/-   ##
============================================
- Coverage     80.09%   80.06%   -0.04%     
  Complexity     1715     1715              
============================================
  Files           159      159              
  Lines          5713     5718       +5     
  Branches        754      754              
============================================
+ Hits           4576     4578       +2     
- Misses          854      856       +2     
- Partials        283      284       +1
Impacted Files Coverage Δ Complexity Δ
...oogle/api/server/spi/swagger/SwaggerGenerator.java 78.34% <100%> (+0.43%) 60 <3> (+1) ⬆️
.../api/server/spi/config/model/SchemaRepository.java 92.42% <100%> (ø) 39 <0> (+1) ⬆️
...a/com/google/api/server/spi/BackendProperties.java 89.28% <0%> (-10.72%) 11% <0%> (-1%)
...c/main/java/com/google/api/server/spi/EnvUtil.java 70% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8643877...0ffa941. Read the comment docs.

@tangiel tangiel merged commit 82710a4 into cloudendpoints:master Oct 24, 2018
@clementdenis clementdenis deleted the unique_operation_id branch February 21, 2022 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants