This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Set CORS-related headers before writing body for flex env support#79
Merged
tangiel merged 1 commit intocloudendpoints:masterfrom Apr 3, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
========================================
Coverage 79.4% 79.4%
Complexity 1618 1618
========================================
Files 154 154
Lines 5449 5449
Branches 702 702
========================================
Hits 4327 4327
Misses 848 848
Partials 274 274
Continue to review full report at Codecov.
|
tangiel
approved these changes
Apr 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On flex env, it seems like custom headers set on the response after writing to the body are not always being written to the final http response.
This causes CORS support not to work with Cloud Endpints v2 on flex env (it works fine on AppEngine standard though).
Simply changing the code to write CORS headers before the response body fixes the issue.
Additionally, it makes any backend error that would happen available to CORS clients as well.