This repository was archived by the owner on Jun 30, 2023. It is now read-only.
cleanup and addition of global pretty print flag#84
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
============================================
- Coverage 79.95% 79.94% -0.01%
+ Complexity 1671 1669 -2
============================================
Files 156 156
Lines 5588 5571 -17
Branches 722 723 +1
============================================
- Hits 4468 4454 -14
+ Misses 842 841 -1
+ Partials 278 276 -2
Continue to review full report at Codecov.
|
tangiel
requested review from
inklesspen
and removed request for
bradfriedman
inklesspen
approved these changes
Feb 28, 2018
This change cleans up ServletInitializationParameters to use AutoValue, since this is a pretty standard value class with a builder. API compatibility is retained except for setIllegalArgumentIsBackendError being renamed to setIllegalArgumentBackendError. The "restricted" parameter is now also marked as deprecated, as it no longer serves any purpose.
This new parameter is a boolean value that controls whether or not prettyPrint is enabled by default. Requests can still enable pretty printing by adding a query parameter if necessary. This value is set to true by default. This value is propagated for each request via EndpointsContext, which requires some amount of refactoring to plumb the value to StandardParameters.shouldPrettyPrint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.