This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Add warning when auth_level is used.#148
Merged
inklesspen merged 1 commit intocloudendpoints:masterfrom Apr 13, 2018
inklesspen:auth_level_warning
Merged
Add warning when auth_level is used.#148inklesspen merged 1 commit intocloudendpoints:masterfrom inklesspen:auth_level_warning
inklesspen merged 1 commit intocloudendpoints:masterfrom
inklesspen:auth_level_warning
Conversation
This parameter is no longer documented, but is probably still in use by some codebases. It does not do anything and never has. This warning paves the way for removing it in a future version.
kryzthov
reviewed
Apr 13, 2018
| AUTH_LEVEL = _Enum(_AUTH_LEVEL_DOCSTRING, 'REQUIRED', 'OPTIONAL', | ||
| 'OPTIONAL_CONTINUE', 'NONE') | ||
| _AUTH_LEVEL_WARNING = ("Due to a design error, auth_level has never actually been functional. " | ||
| "It will likely be removed and replaced by a functioning alternative " |
There was a problem hiding this comment.
Do we actually have plans to provide this functionality?
Contributor
Author
There was a problem hiding this comment.
Eh, I actually considered doing so in this release. It's not too hard. But I decided to ship the release with this warning first to give folks some time to adjust.
Contributor
Author
There was a problem hiding this comment.
So, I'd go with "probably".
kryzthov
approved these changes
Apr 13, 2018
| AUTH_LEVEL = _Enum(_AUTH_LEVEL_DOCSTRING, 'REQUIRED', 'OPTIONAL', | ||
| 'OPTIONAL_CONTINUE', 'NONE') | ||
| _AUTH_LEVEL_WARNING = ("Due to a design error, auth_level has never actually been functional. " | ||
| "It will likely be removed and replaced by a functioning alternative " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter is no longer documented, but is probably still in use by some codebases. It does not do anything and never has. This warning paves the way for removing it in a future version.