Brotli Support through NGINX

[ilyaGurevich]

Does the current version of ESP support a brotli compression through nginx at this moment in time? There is a brotli filter available here

esp/src/nginx/main/ngx_modules.c

Line 218 in 8a6138e

#if (NGX_HTTP_BROTLI_FILTER)

-- but does it require a custom nginx module to be built, or is this already included in the latest version of ESP?

[qiwzhang]

It is not defined here

esp/src/nginx/main/BUILD

Line 102 in 8a6138e

deps = [

So it is NOT in the ESP nginx binary. I believe, it also requires nginx config to enable it. So you need to use custom nginx config.

[ilyaGurevich]

Thanks for the quick response @qiwzhang

Is there any plans to add it in the nginx deps?

[qiwzhang]

Sorry, there was a typo in my previous message, I just corrected it. It is NOT in the ESP nginx binary.

No, we don't have plan to add it.

[qiwzhang]

Sorry, I don't have any example on how to config brotfli compression in nginx config.
Here is the document on how to use custom nginx config in GKE.

[ilyaGurevich]

@qiwzhang sorry I deleted my previous message the one you responded to since I assumed it wasn't possible, however an alternative question:

No, we don't have plan to add it.

If I put in the work to add the brotli configuration to this repo by opening a PR would it be something you would accept? The alternative is to just fork it ourselves and use it separately (which is not ideal to maintain)

By not "planning to add it" does it mean your team won't do it, or it's not something you want in here entirely?

[qiwzhang]

No means we don't have resource to do it. If you can contribute, we will like to get it in.

[ilyaGurevich]

@qiwzhang PR opened here: #784

[ilyaGurevich]

Thank you @qiwzhang for merging the PR - how soon can a release occur?

[qiwzhang]

You just missed this week release. Next release will be in 1 or 2 weeks.

[ilyaGurevich]

@qiwzhang understood -- whenever a release occurs this issue can be closed. Thanks!