Add 2 more values to template vars to make multiple backend support better#694
Conversation
maroux
force-pushed
the
multi_service_template
branch
2 times, most recently
from
18afee2 to
a590f71
Compare
maroux
force-pushed
the
multi_service_template
branch
from
a590f71 to
85bc486
Compare
|
E2E tested failed with errors: Traceback (most recent call last): |
Yep, tests weren't working for my local Mac, so took a few commits to fix 😄 |
| logging.error("[ESP] Service name is not specified"); | ||
| sys.exit(3) | ||
|
|
||
| args.services = args.service.split('|') |
There was a problem hiding this comment.
I think args.services should already be assigned. This line is not needed here, I think
There was a problem hiding this comment.
It is needed because if args.service is not set, and it's fetched from the metadata server, then it's only set in line 361. I suppose this could be moved closer to that to make the association clearer.
There was a problem hiding this comment.
Please don't do too many code refactory. I don't want to break most of users that only using one service
2 participants
This allows us to use a template that can leverage
${services}rather than having to hardcode the list of multiple services when using--experimental_enable_multiple_api_configs.