Skip to content

Log service config rollout fetching error #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiwzhang merged 1 commit into from
Dec 6, 2019
Merged

Log service config rollout fetching error #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions start_esp/fetch_service_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def fetch_metadata(metadata, attr_path, required):
status_code = response.status
if status_code != 200:
if required:
message_template = "Failed fetching metadata attribute: {}, status code {}"
raise FetchError(1, message_template.format(url, status_code))
message_template = "Failed fetching metadata attribute: {}, status code {}, reason {}"
raise FetchError(1, message_template.format(url, status_code, response.data))
else:
return None
return response.data
Expand Down Expand Up @@ -185,7 +185,7 @@ def fetch_latest_rollout(management_service, service_name, access_token):
message_template = ("Fetching rollouts failed "\
"(status code {}, reason {}, url {})")
raise FetchError(1, message_template.format(status_code,
response.reason,
response.data,
service_mgmt_url))
rollouts = json.loads(response.data)
# No valid rollouts
Expand Down Expand Up @@ -217,7 +217,7 @@ def fetch_service_json(service_mgmt_url, access_token):

if status_code != 200:
message_template = "Fetching service config failed (status code {}, reason {}, url {})"
raise FetchError(1, message_template.format(status_code, response.reason, service_mgmt_url))
raise FetchError(1, message_template.format(status_code, response.data, service_mgmt_url))

service_config = json.loads(response.data)
return service_config
Expand Down