Changes for DF Beta inclusion #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NOT_ENABLED status to STOPPED_STATES for Dataflow Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Chaffelson
added a commit
to Chaffelson/cloudera.cloud
that referenced
this pull request
Jun 24, 2021
Dependent on cloudera-labs/cdpy#21 Break out usage of environment name from environment crn Use states from common instead of explicit values for checks Fix check for wait condition when disabling, should wait if requested regardless of whether disable called or not Fix attempting to enable when Environment not present Fix wait for disable incorrectly stipulating that state should be None when it should be checking if field response is None Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Chaffelson
added a commit
to Chaffelson/cloudera.exe
that referenced
this pull request
Jun 24, 2021
Dependent on cloudera-labs/cloudera.cloud#17 Dependent on cloudera-labs/cdpy#21 Add df key to sequence role to handle deploying to defaults when only df is requested Switch request to use Environment crn instead of name for better determinism when user supplies unexpected values Switch from async call to direct call for df enable / disable as it is a 1:1 mapping to environment Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Chaffelson
added a commit
to Chaffelson/cloudera-deploy
that referenced
this pull request
Jun 24, 2021
Dependent on cloudera-labs/cloudera.exe#20 Dependent on cloudera-labs/cloudera.cloud#17 Dependent on cloudera-labs/cdpy#21 Add df key to cloud and cdp public triggers so they are run when df is called solo Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
…is very specific Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
wmudge
approved these changes
Jul 13, 2021
wmudge
pushed a commit
to cloudera-labs/cloudera.cloud
that referenced
this pull request
Jul 13, 2021
* Changes for DF-beta inclusion ** Dependent on cloudera-labs/cdpy#21 * Break out usage of environment name from environment crn * Use states from common instead of explicit values for checks * Fix check for wait condition when disabling, should wait if requested regardless of whether disable called or not * Fix attempting to enable when Environment not present * Fix wait for disable incorrectly stipulating that state should be None when it should be checking if field response is None * Include Dataflow in descendants collation for env_info * Switch to using REMOVABLE_STATES to indicate DF disable capability * Support force removal keyword for DF to enable delete functionality Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
wmudge
pushed a commit
to cloudera-labs/cloudera.exe
that referenced
this pull request
Jul 13, 2021
Dependent on cloudera-labs/cloudera.cloud#17 Dependent on cloudera-labs/cdpy#21 * Add df key to sequence role to handle deploying to defaults when only df is requested * Switch request to use Environment crn instead of name for better determinism when user supplies unexpected values * Switch from async call to direct call for df enable / disable as it is a 1:1 mapping to environment Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
cmperro
pushed a commit
to cmperro/cloudera.cloud
that referenced
this pull request
Aug 12, 2021
* Changes for DF-beta inclusion ** Dependent on cloudera-labs/cdpy#21 * Break out usage of environment name from environment crn * Use states from common instead of explicit values for checks * Fix check for wait condition when disabling, should wait if requested regardless of whether disable called or not * Fix attempting to enable when Environment not present * Fix wait for disable incorrectly stipulating that state should be None when it should be checking if field response is None * Include Dataflow in descendants collation for env_info * Switch to using REMOVABLE_STATES to indicate DF disable capability * Support force removal keyword for DF to enable delete functionality Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com> Signed-off-by: Chris Perro <cmperro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NOT_ENABLED status to STOPPED_STATES for Dataflow
Signed-off-by: Daniel Chaffelson chaffelson@gmail.com