Skip to content

[CYB-125] Updated grok library to io.krakens:java-grok:0.1.9 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carolynduby merged 1 commit into from
Mar 29, 2023
Merged

[CYB-125] Updated grok library to io.krakens:java-grok:0.1.9 #1

carolynduby merged 1 commit into from
Mar 29, 2023

Conversation

@stas-panasiuk
Copy link
Collaborator

@stas-panasiuk stas-panasiuk commented Dec 1, 2022

No description provided.

@stas-panasiuk stas-panasiuk added in progress PR is still in development ready to review PR is ready to review breaking change PR contains breaking change and removed in progress PR is still in development labels Dec 1, 2022
@stas-panasiuk
Copy link
Collaborator Author

stas-panasiuk commented Dec 2, 2022

Breaking change
Now Grok values are by default assumed as strings unless the type is specified in the pattern. The new solution allows specifying one of the following data types: BYTE, BOOLEAN, SHORT, INT, LONG, FLOAT, DOUBLE, DATETIME, STRING. Previously, if the string can be converted to an integer, it happened automatically.

Migration example
Format without type: %{POSINT:pid}. If the value should be treated as an integer, update the format to the following: %{POSINT:pid:int}.

@stas-panasiuk stas-panasiuk added the ready to merge PR is ready to merge label Dec 9, 2022
@vpavlenko-cv vpavlenko-cv removed the ready to review PR is ready to review label Dec 26, 2022
carolynduby
carolynduby reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@carolynduby carolynduby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@carolynduby carolynduby merged commit 6b8d0d1 into develop Mar 29, 2023
@carolynduby carolynduby deleted the CYB-125 branch March 29, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carolynduby carolynduby carolynduby left review comments

@vpavlenko-cv vpavlenko-cv vpavlenko-cv approved these changes

Assignees

No one assigned

Labels

breaking change PR contains breaking change ready to merge PR is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stas-panasiuk @carolynduby @vpavlenko-cv