Skip to content

Conversation

@stas-panasiuk
Copy link
Collaborator

No description provided.

@stas-panasiuk stas-panasiuk added checked on a cluster The code has been tested on a cluster. ready to review PR is ready to review labels May 2, 2023
nz-input
[formControl]="controls[i]"
(keyup)="onChange(config)"
(keyup.enter)="onAddClick()"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a different action based on whether multipleValues = true or false. In the current implementation, pressing enter on a field where multipleValues=false, adds another value to that field which won't work.

Copy link
Collaborator

@carolynduby carolynduby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@carolynduby carolynduby merged commit c998dad into develop May 3, 2023
@carolynduby carolynduby deleted the CYB-148 branch May 3, 2023 20:32
mikepresseau pushed a commit that referenced this pull request Nov 14, 2025
CYB-78 Buil order problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checked on a cluster The code has been tested on a cluster. ready to review PR is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants