-
Notifications
You must be signed in to change notification settings - Fork 2
[CYB-4;CYB-137] TableAPI Flink Indexer + Parser UI updates #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # flink-cyber/flink-cyber-api/src/main/java/com/cloudera/cyber/indexing/MappingColumnDto.java # flink-cyber/flink-cyber-api/src/main/java/com/cloudera/cyber/indexing/MappingDto.java # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/custom-form/components/multi-input/multi-input.component.html # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/custom-form/custom-form.component.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/model/describe/ConfigParamDescriptor.java
# Conflicts: # flink-cyber/cyber-jobs/src/main/resources/scripts/cs-add-index # flink-cyber/flink-indexing/flink-indexing-hive/pom.xml
This was referenced Jun 13, 2023
Collaborator
|
UI looks good |
# Conflicts: # flink-cyber/flink-cyber-api/src/main/java/com/cloudera/cyber/ThreatIntelligence.java
vpavlenko-cv
approved these changes
Jun 28, 2023
carolynduby
requested changes
Jul 1, 2023
Collaborator
carolynduby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the scripts and provide an example config.
flink-cyber/cyber-jobs/src/main/resources/conf/templates/index/index.properties.template
Show resolved
Hide resolved
flink-cyber/cyber-jobs/src/main/resources/conf/templates/index/index.properties.template
Show resolved
Hide resolved
flink-cyber/cyber-jobs/src/main/resources/scripts/cs-restart-index
Outdated
Show resolved
Hide resolved
carolynduby
approved these changes
Jul 12, 2023
Collaborator
carolynduby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checked on a cluster
The code has been tested on a cluster.
next release
High priority Pull Requests that should be merged first
ready to review
PR is ready to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableAPI Flink Hive Indexing implementation;
Parser ui allows user to choose from columns defined in indexing schema