Dynamic mqtt port for unit tests#346
Merged
jskeet merged 1 commit intocloudevents:mainfrom Apr 27, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Erwin <erwinkramer@hotmail.com>
jskeet
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR assigns a dynamic port number during mqtt server start and also moves from
NewtonsoftJsonformatter toSystemTextJsonin the mqtt tests.Should solve port conflicts like https://github.com/cloudevents/sdk-csharp/actions/runs/24733076929/job/72352560560?pr=345#step:4:102. I assume because the .net8 and .net10 tests currently have a race condition to both claim port
52355.Related to #192.
I verified by starting 2 mqtt servers async, with similar
MqttServerOptionssetup, that seems to handle it fine: