Run workflow on Windows too; and when on Windows, run the net48 tests explicitly#355
Merged
Merged
Conversation
Signed-off-by: Erwin Kramer <e.a.s.kramer@dnb.nl>
jskeet
approved these changes
May 18, 2026
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Looks good to me. I'm not too worried about not running things in parallel - it's not a hugely slow test set anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Succeeding #353.
I made the test runners explicitly target net8, net10 and net48, because https://github.com/actions/setup-dotnet doesn't support net48. This causes them to not run parallel anymore, but I couldn't see an elegant solution to keep them parallel. However, both Linux and windows run in parallel now, and Windows is slower than Linux now anyway.