-
Notifications
You must be signed in to change notification settings - Fork 7
Implement publish script #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SimeonGerginov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
If you prefix your commit with |
ccb2d78 to
258edd8
Compare
Signed-off-by: Dimitar Milov <dmilov@vmware.com> Add publish job to run on version tag Signed-off-by: Dimitar Milov <dmilov@vmware.com> Segregate build and publish in steps Use 'release' working directory for the release job Use dir name instead of path Signed-off-by: Dimitar Milov <dmilov@vmware.com> test publish script Signed-off-by: Dimitar Milov <dmilov@vmware.com> Create output directory if it doesn't exist REmove resolve path to avoid failures in case of unexisting directory Signed-off-by: Dimitar Milov <dmilov@vmware.com> Work with full path Signed-off-by: Dimitar Milov <dmilov@vmware.com> Trigger action on tag create Signed-off-by: Dimitar Milov <dmilov@vmware.com> Add create github release step Signed-off-by: Dimitar Milov <dmilov@vmware.com> Create changle log step in the Release job Signed-off-by: Dimitar Milov <dmilov@vmware.com> Use PowerShell to run docker container for the CHANGELOG creation Signed-off-by: Dimitar Milov <dmilov@vmware.com> Run release job on ubuntu fot he purpose of the changelog creation Signed-off-by: Dimitar Milov <dmilov@vmware.com> Use default shell for docker command Signed-off-by: Dimitar Milov <dmilov@vmware.com> Use the tag for gh release Signed-off-by: Dimitar Milov <dmilov@vmware.com> Pick up changelog from previous step Signed-off-by: Dimitar Milov <dmilov@vmware.com> Rename workflow to 'release' Signed-off-by: Dimitar Milov <dmilov@vmware.com> Address PR review comments Signed-off-by: Dimitar Milov <dmilov@vmware.com>
8ac9857 to
78b7e9e
Compare
embano1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX a ton!
|
Approved! Note: if you prefix the commit with |
Signed-off-by: Dimitar Milov dmilov@vmware.com
Add publish job to run on version tag
Signed-off-by: Dimitar Milov dmilov@vmware.com
Description
Implement a publishing script that
Add GHA to trigger the publish script on version tag
Closes: #32
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.
Test Configuration:
Checklist:
guidelines
of this project