Skip to content

Changes per TAG Contrib Strategy review#1224

Merged
duglin merged 1 commit intocloudevents:mainfrom
duglin:tag-review
Sep 14, 2023
Merged

Changes per TAG Contrib Strategy review#1224
duglin merged 1 commit intocloudevents:mainfrom
duglin:tag-review

Conversation

@duglin
Copy link
Collaborator

@duglin duglin commented Sep 11, 2023

Misc edits per the TAG Contrib Strategy Review: cncf/tag-contributor-strategy#509

README.md Outdated
- Slack: #cloudeventssdk on [CNCF's Slack workspace](http://slack.cncf.io/)

For SDK specific communications, please see the main README in each
SDK's github repo - see the list of [SDKs above](#sdks).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly change the link text to "list of SDKs" rather than "SDKs above"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

project will manage this repository.

For easy reference, additional documentation related to how this project
(and it's subprojects) operate are listed below:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's => its

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And I'd probably remove the parentheses - otherwise if you ignore the parenthetical part, you get a singular/plural mismatch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Doug Davis <dug@microsoft.com>
@duglin
Copy link
Collaborator Author

duglin commented Sep 14, 2023

As always, thanks for the review @jskeet

Approved on the 9/14 call.

@duglin duglin merged commit 7f0d456 into cloudevents:main Sep 14, 2023
@duglin duglin deleted the tag-review branch September 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants