Add clarity text and an example of versioning eventTypes#340
Merged
duglin merged 2 commits intocloudevents:masterfrom Nov 29, 2018
Merged
Add clarity text and an example of versioning eventTypes#340duglin merged 2 commits intocloudevents:masterfrom
duglin merged 2 commits intocloudevents:masterfrom
Conversation
duglin
force-pushed
the
versionEventType
branch
from
c8bff17 to
3514470
Compare
duglin
commented
Nov 8, 2018
| the organization which defines the semantics of this event type. | ||
| * Examples | ||
| * com.github.pull.create | ||
| * com.example.object.v2.delete |
Collaborator
Author
There was a problem hiding this comment.
com.example.object.delete.v2
Just because Austen wanted to see it. Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin
force-pushed
the
versionEventType
branch
from
3514470 to
f3da98b
Compare
Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin
force-pushed
the
versionEventType
branch
from
f3da98b to
6fe49f2
Compare
Collaborator
Author
|
@clemensv see if the text I added is headed in the direction you were thinking of on the call the other day. Any suggested edits are welcome - from anyone. |
Collaborator
Author
|
@clemensv any comment on the latest edits? |
Contributor
|
I like the guidance part. LGTM. |
Collaborator
Author
|
Approved on 11/29 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just because @ac360 wanted to see it.
Signed-off-by: Doug Davis dug@us.ibm.com