clarifications to address concerns raised in issue 185#343
Merged
duglin merged 4 commits intocloudevents:masterfrom Nov 29, 2018
Merged
clarifications to address concerns raised in issue 185#343duglin merged 4 commits intocloudevents:masterfrom
duglin merged 4 commits intocloudevents:masterfrom
Conversation
Signed-off-by: clemensv <clemensv@microsoft.com>
Collaborator
|
@clemensv rebase needed |
added 3 commits
November 28, 2018 16:05
Signed-off-by: clemensv <clemensv@microsoft.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
Vlaaaaaaad
approved these changes
Nov 28, 2018
Vlaaaaaaad
left a comment
Vlaaaaaaad
left a comment
There was a problem hiding this comment.
LGTM, but not at all my area.
Had a small question regarding time, but that's more as a clarification.
| | URI-reference | [string][JSON-String] | ||
| | Timestamp | [string][JSON-String] | ||
| | URI-reference | [string][JSON-String] following [RFC 3986][RFC3986] | ||
| | Timestamp | [string][JSON-String] following [RFC 3339][RFC3339] (ISO 8601) |
There was a problem hiding this comment.
From what I see there seem to be small differences between RFC3339 and ISO 8601 ad per the Usage section in https://en.wikipedia.org/wiki/ISO_8601.
Is supporting them both desired? Should we be more specifics? Do SDKs need to detect and parse?
Contributor
Author
There was a problem hiding this comment.
RFC3339: " This document defines a date and time format for use in Internet
protocols that is a profile of the ISO 8601 standard for
representation of dates and times using the Gregorian calendar."
RFC3339 is ISO8601, with limits
Collaborator
|
Approved on 11/29 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: clemensv clemensv@microsoft.com
Closes #185