Add some rationale for our extensions decision#353
Merged
duglin merged 1 commit intocloudevents:masterfrom Nov 29, 2018
Merged
Conversation
The Primer is a good location to document some of our design decisions without cluttering the spec with non-normative text. This is my first pass at some of the reasons why we're serializing extensions as top-level properties in JSON. Note, as you review this please focus on whether the text accurately reflects the reasons why we ended up with our current design. This PR should not be used to question whether it was a good or bad decision. If you want to question the decision itself then a new issue (or PR) is the best place to do that - I'm just trying to document history. Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin
force-pushed
the
primerExtensions
branch
from
06698d6 to
ba8ad6f
Compare
Collaborator
Author
|
Approved on 11/29 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Primer is a good location to document some of our design decisions
without cluttering the spec with non-normative text. This is my first pass
at some of the reasons why we're serializing extensions as top-level
properties in JSON.
Note, as you review this please focus on whether the text accurately
reflects the reasons why we ended up with our current design. This PR
should not be used to question whether it was a good or bad decision.
If you want to question the decision itself then a new issue (or PR) is the
best place to do that - I'm just trying to document history.
Signed-off-by: Doug Davis dug@us.ibm.com