fix(workflows): await _workflow_updateState RPC calls in _wrapStep#1071
Merged
threepointone merged 1 commit intomainfrom Mar 5, 2026
Merged
fix(workflows): await _workflow_updateState RPC calls in _wrapStep#1071threepointone merged 1 commit intomainfrom
threepointone merged 1 commit intomainfrom
Conversation
updateAgentState, mergeAgentState, and resetAgentState were not awaiting the RPC call inside step.do(), causing state updates to be silently lost when the Workflows engine marked the step as complete before the RPC was delivered. fixes #1067
🦋 Changeset detectedLatest commit: 9d1eaaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds missing
awaitto three_workflow_updateStateRPC calls insidestep.do()callbacks inAgentWorkflow._wrapStep().Affected methods:
updateAgentState,mergeAgentState,resetAgentStateWithout
await, thestep.do()callback returns immediately, the Workflows engine marks the step as durably completed, and the workflow moves on — but the RPC may not have been delivered to the Agent yet. This can cause state updates to be silently lost.The other wrapped methods (
reportComplete,reportError,sendEvent) already correctlyawaittheir RPC calls.Fixes #1067
Credit to @zeke for the detailed writeup and root cause analysis.