Fix abort duplicate split messages#1106
Merged
threepointone merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 842e9a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Prevent duplicate assistant messages when a user aborts a live stream by keeping the requestId marked active until the server sends done:true. WebSocketChatTransport.finish now accepts a keepId flag and onAbort retains the requestId so in-flight server chunks are skipped by the dedup guard. useAgentChat.onAgentMessage now removes the kept ID when it sees data.done to avoid a minor memory leak. Added a test to verify the requestId is preserved after abort and cleaned up after the server's done broadcast, and included a changeset entry.
Add a waitFor helper in resumable-streaming.test.ts and replace fragile setTimeout-based waits with condition-based polling. The helper polls a condition until a timeout (default 2000ms, interval 50ms). This makes the test wait for the full ACK → DB flush → replay round-trip and for replayed chunks (e.g. delta "B") to appear, improving reliability and reducing flakiness without changing test behavior.
threepointone
force-pushed
the
fix-abort-duplicates
branch
from
bfaa1eb to
4c879a8
Compare
Extend waitFor to accept and await async conditions (boolean | Promise<boolean>), and replace multiple ad-hoc setTimeout sleeps in resumable-streaming.test.ts with explicit waitFor checks (e.g. message count conditions and agentStub.getActiveStreamId() === null). This makes the tests more deterministic by removing arbitrary delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1100
Prevent duplicate assistant messages when a user aborts a live stream by keeping the requestId marked active until the server sends done:true. WebSocketChatTransport.finish now accepts a keepId flag and onAbort retains the requestId so in-flight server chunks are skipped by the dedup guard. useAgentChat.onAgentMessage now removes the kept ID when it sees data.done to avoid a minor memory leak. Added a test to verify the requestId is preserved after abort and cleaned up after the server's done broadcast, and included a changeset entry.