Forward positionalArgs to resolved providers#1181
Merged
threepointone merged 6 commits intomainfrom Mar 24, 2026
Merged
Conversation
Preserve provider.positionalArgs when resolving ToolProviders so multi-argument tool calls don't lose positional arguments. Update createCodeTool in both tanstack-ai.ts and tool.ts to copy positionalArgs into ResolvedProvider when present. Add unit tests verifying positionalArgs is forwarded or omitted appropriately, and add a changeset noting the fix.
🦋 Changeset detectedLatest commit: 523203c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Wrap duplicate-schedule warning emission in a try/catch so any errors while warning/emit-ing won't block row processing. Move JSON.parse(row.payload) into the execute try block to avoid parsing exceptions happening before related events are emitted. Update tests accordingly: insert null payloads instead of JSON.stringify(undefined), delay setAlarm by 1s to avoid immediate processing, increase close wait timeout and poll for disconnect events to accomodate Workers runtime/hibernation timing.
Expose a callable setStoredAlarm on TestScheduleAgent and update schedule tests to use agentStub.clearStoredAlarm(), setStoredAlarm(), and backdateSchedule() instead of manipulating ctx.storage inside durable object callbacks. This avoids races with the auto-scheduled alarm and makes deterministic alarm firing in the tests by clearing, backdating, then re-arming the stored alarm before calling runDurableObjectAlarm.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve provider.positionalArgs when resolving ToolProviders so multi-argument tool calls don't lose positional arguments. Update createCodeTool in both tanstack-ai.ts and tool.ts to copy positionalArgs into ResolvedProvider when present. Add unit tests verifying positionalArgs is forwarded or omitted appropriately, and add a changeset noting the fix.