fix: preserve voice text across streamed tool gaps#1525
Draft
whoiskatrin wants to merge 5 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 2203a85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role: \"assistant\"text → tool → text → tool → textstream, plus the required@cloudflare/voicepatch changesetProblem
A voice user reported that when an agent streams:
the WebSocket client does not receive the assistant text between tool calls until the stream ends, so voice playback starts late and reads the accumulated text together.
For OpenAI/OpenRouter-style raw SSE streams, later assistant content deltas may omit
roleafter the initial assistant chunk.iterateText()previously required every content delta to includerole: \"assistant\", so later text chunks in the same assistant stream were skipped.Fix
iterateText()now remembers when an OpenAI-style stream is currently emitting assistant deltas. Once an assistant role is established, subsequent content deltas without a repeatedroleare still yielded until another role appears.This keeps assistant text available to
withVoiceacross intervening tool-call chunks instead of dropping the in-between and final text segments.Reviewer notes
The core behavior change is in:
packages/voice/src/text-stream.tsThe regression coverage is intentionally parser-level because that is where the bug occurs:
text → tool → text → tool → textSee:
packages/voice/src/tests/text-stream.test.ts.changeset/bright-voices-stream.mdValidation
npm run test -- src/tests/text-stream.test.ts -w @cloudflare/voicenpm run checkpackages/thinkandexamples/think-submissions