fix(codemode): use Workers-safe MCP validator#1555
Merged
Conversation
🦋 Changeset detectedLatest commit: 7082991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattzcarey
force-pushed
the
fix/issue-1491
branch
from
a7af011 to
ee3d12f
Compare
mattzcarey
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mattzcarey
force-pushed
the
fix/issue-1491
branch
from
ee3d12f to
7082991
Compare
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
threepointone
approved these changes
May 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openApiMcpServercurrently creates its underlying MCPMcpServerwithout server options, which leaves the MCP SDK on its default AJV validator. AJV compiles schemas with runtime code generation, so elicitation accept responses can fail in Cloudflare Workers withCode generation from strings disallowed.This PR defaults codemode's OpenAPI MCP server to the SDK's Workers-safe
CfWorkerJsonSchemaValidator, avoiding AJV codegen for elicitation response validation.Changes
CfWorkerJsonSchemaValidatorwhen constructing the underlyingMcpServerinopenApiMcpServer.openApiMcpServeruses the Workers-safe validator by default.@cloudflare/codemode.Fixes #1491.
Testing
npm test --workspace @cloudflare/codemodenpm run build --workspace @cloudflare/codemodenpm run buildnpm run check— currently blocked by existing missing dependency/type resolution for@cloudflare/kumoinsite/ai-playground/tsconfig.json; all other check steps pass, including sherif, export validation, format, lint, and 83/84 typecheck projects.