Skip to content

Use Cloudflare-AI-playground as client name instead of sessionId for playground #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whoiskatrin merged 1 commit into from
Nov 1, 2025
Merged

Use Cloudflare-AI-playground as client name instead of sessionId for playground #622

whoiskatrin merged 1 commit into from
Nov 1, 2025

Conversation

@Maximo-Guk
Copy link
Member

@Maximo-Guk Maximo-Guk commented Nov 1, 2025

This looks a lot friendlier
Screenshot 2025-10-31 at 8 25 54 PM

than this!
Screenshot 2025-10-31 at 8 23 50 PM

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 224b388

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Maximo-Guk
Maximo-Guk commented Nov 1, 2025
View reviewed changes
site/ai-playground/src/components/Header.tsx
<a
className="hover:bg-gray-50 text-sm cursor-pointer font-sm px-3 py-2 bg-white border border-gray-200 rounded-md shadow-sm flex items-center"
href="https://github.com/cloudflare/agents/tree/main/examples/ai-playground"
href="https://github.com/cloudflare/agents/tree/main/site/ai-playground"
Copy link
Member Author

@Maximo-Guk Maximo-Guk Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed this broken link!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 1, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/agents@622

commit: 224b388

threepointone
threepointone reviewed Nov 1, 2025
View reviewed changes
site/ai-playground/src/app.tsx Outdated
const agent = useAgent<Playground, PlaygroundState>({
agent: "playground",
name: sessionId,
name: "Cloudflare-AI-Playground",
Copy link
Contributor

@threepointone threepointone Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make every client connect to the same agent instance. Maybe it can be Cloudflare-Ai-playground-:id?

Copy link
Member Author

@Maximo-Guk Maximo-Guk Nov 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@Maximo-Guk Maximo-Guk force-pushed the maximo/use-cloudflare-ai-playground-name branch from 2187d6c to 224b388 Compare November 1, 2025 01:35
threepointone
threepointone approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you very much!

@whoiskatrin whoiskatrin merged commit 3668b9c into cloudflare:main Nov 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@threepointone threepointone threepointone approved these changes

@whoiskatrin whoiskatrin whoiskatrin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk @threepointone @whoiskatrin