fix: pass tool_choice through to binding.run()#429
Merged
threepointone merged 2 commits intocloudflare:mainfrom Mar 9, 2026
Merged
fix: pass tool_choice through to binding.run()#429threepointone merged 2 commits intocloudflare:mainfrom
threepointone merged 2 commits intocloudflare:mainfrom
Conversation
tool_choice was computed by prepareToolsAndToolChoice() but never included in the object returned by buildRunInputs(), silently dropping it before reaching the model. This caused toolChoice options like "required" to be ignored.
🦋 Changeset detectedLatest commit: ae24f06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
approved these changes
Mar 9, 2026
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #404
tool_choicewas computed byprepareToolsAndToolChoice()but never included in the inputs passed tobinding.run(), silently dropping it. Models that require an explicittool_choiceto call tools (e.g. mistral, granite, deepseek) would acknowledge tools in their text response but never actually invoke them.Changes
tool_choiceinto binding inputs when presenttool_choice: undefinedin the JSON response format path where tools are suppressed"auto"and"required"→"any"mapping