-
Notifications
You must be signed in to change notification settings - Fork 9
More generic sequencer features #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice, these are great changes!
Hmm I'm not sure I follow. The
Oh yeah, right now
That's right--and that would be great! We'll need that for the Merkle Tree CA as well. |
|
Ok I removed swap_checkpoint. I think that was the last thing |
Sorry for the huge commit. This does a bunch of stuff:
ProofPreparerthat only records the tiles it's asked for. We then fetch those tiles and produce a proof using that data.Checkpoint::newto accept&[&str]for the extensions sectionGenericSequencergeneric overLogEntryrather thanPendingLogEntry. This was just so thatload_sequence_statecould be defined (since it requires knowledge of the log entry type)Some issues I ran into:
fetch("/add-entry").awaitand then callingseq.checkpoint()does not work. This is because the fetch completes when the item is sequenced by the DOalarm(), and this occurs before the alarm gets to update the checkpoint. So I need a way of awaiting the full sequencing operation, including the checkpoint update. Any ideas on this? My first thought is to make an/add-entryoptional field that tells it to only return when the checkpoint is updated, and have that in turn initialize an optional channel that gets terminated once the checkpoint is updated.Checkpointtype does not permit signature lines. This is odd because a checkpoint is just a special kind of signed note. I'll go ahead and make this fix separately.