CStr vs UTF-8 improvements #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghedo
approved these changes
Sep 26, 2025
|
|
||
| /// Returns a short string describing the state of the session. | ||
| /// | ||
| /// Returns empty string if the state wasn't valid UTF-8 |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns empty string if the state wasn't valid UTF-8 | |
| /// Returns empty string if the state wasn't valid UTF-8. |
|
|
||
| /// Returns a longer string describing the state of the session. | ||
| /// | ||
| /// Returns empty string if the state wasn't valid UTF-8 |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns empty string if the state wasn't valid UTF-8 | |
| /// Returns empty string if the state wasn't valid UTF-8. |
|
|
||
| /// Return a human readable error string from the verification error. | ||
| /// | ||
| /// Returns empty string if the message was not UTF-8 |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns empty string if the message was not UTF-8 | |
| /// Returns empty string if the message was not UTF-8. |
|
|
||
| /// # Safety | ||
| /// | ||
| /// MUST be UTF-8 |
Member
There was a problem hiding this comment.
Suggested change
| /// MUST be UTF-8 | |
| /// MUST be UTF-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.