Add binding for X509_check_ip_asc #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good, would be nice to include a link to https://boringssl.googlesource.com/boringssl.git/+/refs/heads/master/include/openssl/x509.h#4690 in the commit description. Is writing a test too arduous? |
evanrittenhouse
force-pushed
the
evanrittenhouse/check_ip_asc
branch
from
aee62f5 to
87353c7
Compare
Contributor
Author
|
Added link and test |
evanrittenhouse
force-pushed
the
evanrittenhouse/check_ip_asc
branch
from
87353c7 to
6bc941f
Compare
rushilmehra
reviewed
Sep 4, 2025
rushilmehra
approved these changes
Sep 4, 2025
Contributor
Author
|
Good call on the test 😛 , shoutout clippy. Will need a release as well |
evanrittenhouse
force-pushed
the
evanrittenhouse/check_ip_asc
branch
from
2883b64 to
8a4c060
Compare
The binding corresponds to https://boringssl.googlesource.com/boringssl.git/+/refs/heads/master/include/openssl/x509.h#4690. To see the SANs covered by the specified cert, use: ```shell ❯ openssl x509 -in ./boring/test/alt_name_cert.pem -noout -text | grep -A1 "Subject Alternative Name" X509v3 Subject Alternative Name: DNS:example.com, IP Address:127.0.0.1, IP Address:0:0:0:0:0:0:0:1, email:test@example.com, URI:http://www.example.com ```
evanrittenhouse
force-pushed
the
evanrittenhouse/check_ip_asc
branch
from
8a4c060 to
0ab00a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to https://boringssl.googlesource.com/boringssl.git/+/refs/heads/master/include/openssl/x509.h#4690