-
Notifications
You must be signed in to change notification settings - Fork 148
Release backported v4 boring and boring-sys
#406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushilmehra
approved these changes
Dec 5, 2025
Collaborator
|
Lgtm but let's drop a note somewhere about not releasing backported hyper-boring |
Collaborator
Author
|
To simplify, I've rebased without the hyper-boring commit, so now the branch is fully-back compat (hyper-boring didn't change). The previous commit there was to keep more of shared history with the main branch, but in retrospect that was unnecessary complication for git aesthetics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are cherry-picked backwards-compatible changes in
boringandboring-sys(but nothyper-boring, don't release that one).I think we should release the bugfixes and improvements we have that can work in v4, because v5 is a semver-major upgrade and may take a while to get adopted.